Perhaps we should just ignore all errors in dtor as the same way the stdlib does it. If the user cares about errors during close, they must call close() themselves. Otherwise, the dtor calls close and ignores all errors from the call.

Perhaps we should just ignore all errors in dtor as the same way the stdlib does it. If the user cares about errors during close, they must call close() themselves. Otherwise, the dtor calls close and ignores all errors from the call.

That was previous behavior, but it does not looks safe, since "user" (developer) can forget about calling one of finalize/sync/next and the error will be simply ignored (and not only forgotten but also if something will be thrown in between), w/o any error provided to user.

Perhaps we should just ignore all errors in dtor as the same way the stdlib does it. If the user cares about errors during close, they must call close() themselves. Otherwise, the dtor calls close and ignores all errors from the call.

That was previous behavior, but it does not looks safe, since "user" (developer) can forget about calling one of finalize/sync/next and the error will be simply ignored (and not only forgotten but also if something will be thrown in between), w/o any error provided to user.

But we should not throw in dtor anyway.

Destructors are noexcept by default. We can annotate it with noexcept(false) and check if there is any std::uncaught_exception on the fly. If yes, we log the exception. If no, we throw.

Destructors are noexcept by default.

Right

We can annotate it with noexcept(false) and check if there is any std::uncaught_exception on the fly. If yes, we log the exception. If no, we throw.

I tried to do this, but the problem is - there is too much classes that should be changed (including poco).

And actually to me it is better to terminate the server if the write failed instead of writing error the log, someone may miss this and the data will be lost.
My initial plan was to do this and make all the callers safe to avoid abnormal server terminations.

Also note, that this patches are still make sense by themselves (regardless #19451)

➕

We should not make destructors noexcept(false).
std::terminate in destructors is Ok.

00992_system_parts_race_condition_zookeeper

Broken after merging NuRaft.

AST fuzzer (TSan) — Lost connection to server. See the logs.

OOM.