Fix function neighbor for LowCardinality argument.#19617
Merged
alexey-milovidov merged 3 commits intomasterfrom Jan 28, 2021
Merged
Fix function neighbor for LowCardinality argument.#19617alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
|
|
||
| bool useDefaultImplementationForConstants() const override { return false; } | ||
|
|
||
| bool useDefaultImplementationForLowCardinalityColumns() const override { return false; } |
Member
There was a problem hiding this comment.
What is the point? Why it was working wrong?
Member
Author
There was a problem hiding this comment.
The optimization happened. Function was executed over dictionary
Member
There was a problem hiding this comment.
Could you please add a comment?
alexey-milovidov
approved these changes
Jan 27, 2021
This was referenced Jan 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 28, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Feb 1, 2021
Backport #19617 to 21.1: Fix function neighbor for LowCardinality argument.
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
Backport #19617 to 20.12: Fix function neighbor for LowCardinality argument.
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
Backport #19617 to 20.11: Fix function neighbor for LowCardinality argument.
This was referenced Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 18, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Feb 19, 2021
Backport #19617 to 20.8: Fix function neighbor for LowCardinality argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong result of function
neighborforLowCardinalityargument. Fixes #10333