Cherry pick #19449 to 21.1: Mark distributed batch as broken in case of empty data block in one of files#19502
Merged
vitlibar merged 4 commits intobackport/21.1/19449from Feb 1, 2021
Conversation
…tributed It is possible to get corruption (even though it is very unlikely, and initially it wasn't corruption) just before the data block goes in the file on disk, and in case of batching, it will break the packets, since it will write the packet type but will not write any data after.
Mark distributed batch as broken in case of empty data block in one of files
robot-clickhouse
added
do not test
added 2 commits
February 1, 2021 20:18
…84097e8e308e902dc53be0fec7e
vitlibar
deleted the
cherrypick/21.1/7f059e376559784097e8e308e902dc53be0fec7e
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #19449
This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command
git cherry-pick.If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Also this pull-request will be merged automatically as it reaches the mergeable state, but you always can merge it manually.