Mark distributed batch as broken in case of empty data block in one of files#19449
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jan 23, 2021
Merged
Conversation
…tributed It is possible to get corruption (even though it is very unlikely, and initially it wasn't corruption) just before the data block goes in the file on disk, and in case of batching, it will break the packets, since it will write the packet type but will not write any data after.
robot-clickhouse
added
the
pr-bugfix
azat
changed the title
alexey-milovidov
approved these changes
Jan 22, 2021
This was referenced Jan 23, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 26, 2021
… empty data block in one of files
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 26, 2021
… empty data block in one of files
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
…9784097e8e308e902dc53be0fec7e Cherry pick #19449 to 21.1: Mark distributed batch as broken in case of empty data block in one of files
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
Backport #19449 to 20.12: Mark distributed batch as broken in case of empty data block in one of files
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
Backport #19449 to 20.11: Mark distributed batch as broken in case of empty data block in one of files
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 17, 2021
…empty data block in one of files
alexey-milovidov
added a commit
that referenced
this pull request
Feb 19, 2021
Backport #19449 to 21.1: Mark distributed batch as broken in case of empty data block in one of files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Mark distributed batch as broken in case of empty data block in one of files
Detailed description / Documentation draft:
It is possible to get corruption (even though it is very unlikely, and
initially it wasn't corruption, but ignored exception - #19451) just before the data block goes in the
file on disk, and in case of batching, it will break the packets, since
it will write the packet type but will not write any data after.