[wip] support RANGE frame for window functions#19299
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
akuzm
changed the title
Member
|
Failure in test keeper #18950. |
Contributor
Author
|
Fuzzer #19579 |
Contributor
Author
|
Integration test failures are not related to the PR. |
Alex-Cheng
reviewed
Mar 1, 2023
| } | ||
|
|
||
| // Consume input data if we have any ready. | ||
| if (!has_input && input.hasData()) |
Contributor
There was a problem hiding this comment.
Is the variable has_input required? I see the input.pullData(true) has set the input as 'not needed' and the status is Ready. Is it any possibility that another input data block comes before work() executes? There is a queue blocks for input data blocks in work().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):