Skip to content

Add metrics for part number in MergeTree in ClickHouse#19122

Merged
alexey-milovidov merged 3 commits intomasterfrom
data-part-better-code
Jan 15, 2021
Merged

Add metrics for part number in MergeTree in ClickHouse#19122
alexey-milovidov merged 3 commits intomasterfrom
data-part-better-code

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jan 15, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Rewrite of #18955.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 15, 2021
@alexey-milovidov alexey-milovidov changed the title Slightly better code of IMergeTreeDataPart #18955 Add metrics for part number in MergeTree in ClickHouse Jan 15, 2021
@alexey-milovidov alexey-milovidov merged commit 5f189c5 into master Jan 15, 2021
@alexey-milovidov alexey-milovidov deleted the data-part-better-code branch January 15, 2021 21:20
@alexey-milovidov
Copy link
Copy Markdown
Member Author

@azat Metrics for data part types can be added very easily (single MetricIncrement inside each part type class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants