Revert "Revert "Add metrics for part number in MergeTree in ClickHouse""#18955
Revert "Revert "Add metrics for part number in MergeTree in ClickHouse""#18955alexey-milovidov wants to merge 3 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
| M(Parts, "Total number of data parts") \ | ||
| M(PartsActive, "Number of active data parts") \ | ||
| M(PartsInactive, "Number of inactive data parts") \ |
There was a problem hiding this comment.
I was recently thought about these metrics and maybe it worth track separate counters for wide/compact/memory parts? (since limits for number of in-memory parts should be different)
There was a problem hiding this comment.
Yes, it will be useful. BTW, you can create another PR that will include this PR.
There was a problem hiding this comment.
I will take a look at this later. Since I want to rethink some code around, in particular, max_partitions_per_insert_block for in-memory data parts 100 does not looks like good threshold
|
The test does not work even with infinite retries. BTW, I don't like the idea to maintaining the consistency manually. |
|
But it will be inefficient for large number of data parts. |
|
There is already |
3 participants
Reverts #18834
Revive changes that were reverted due to instable test.
Changelog category: