Merged
Conversation
Member
Author
|
Our escaping manipulators are very confusing: https://github.com/ClickHouse/ClickHouse/blob/fix_mutation_commands_escaping/src/IO/Operators.h#L59-L64. |
tavplubix
approved these changes
Jan 12, 2021
This was referenced Jan 12, 2021
Member
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 12, 2021
alesapin
added a commit
that referenced
this pull request
Jan 13, 2021
Backport #18944 to 20.12: Fix mutations text serialization
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 13, 2021
alesapin
added a commit
that referenced
this pull request
Jan 15, 2021
Backport #18944 to 21.1: Fix mutations text serialization
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 15, 2021
alesapin
added a commit
that referenced
this pull request
Jan 16, 2021
Backport #18944 to 20.10: Fix mutations text serialization
alexey-milovidov
added a commit
that referenced
this pull request
Jan 16, 2021
Backport #18944 to 20.11: Fix mutations text serialization
Member
|
FYI this bug was not present in any ClickHouse release. |
This was referenced Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 18, 2021
tavplubix
added a commit
that referenced
this pull request
Feb 20, 2021
Backport #18944 to 20.8: Fix mutations text serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug when mutation with some escaped text (like
ALTER ... UPDATE e = CAST('foo', 'Enum8(\'foo\' = 1')serialized incorrectly. Fixes #18878.