Drop RESTART REPLICAS from stateless tests to avoid locking lots of mutexes#18897
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Jan 11, 2021
Merged
Conversation
…utexes Under TSan you can lock only not more then 64 mutexes from one thread at once [1] [2], while RESTART REPLICAS can acquire more (it depends on the number of replicated tables). [1]: google/sanitizers#950 (comment) [2]: https://github.com/llvm/llvm-project/blob/b02eab9058e58782fca32dd8b1e53c27ed93f866/compiler-rt/lib/sanitizer_common/sanitizer_deadlock_detector.h#L67 And since stress tests run tests in parallel, you can have more then 64 ReplicatedMergeTree tables at once (even though it is unlikely). Fix this by using RESTART REPLICA table over RESTART REPLICAS.
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Jan 10, 2021
azat
changed the title
Member
@alesapin What's wrong? |
alexey-milovidov
added
the
st-need-info
Member
Suspicious. |
Member
??? |
Member
|
These changes useful and don't related to the failure. Will investigate separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Drop RESTART REPLICAS from stateless tests to avoid locking lots of mutexes
Under TSan you can lock only not more then 64 mutexes from one thread at
once 1 2, while RESTART REPLICAS can acquire more (it depends on the
number of replicated tables).
And since stress tests run tests in parallel, you can have more then 64
ReplicatedMergeTree tables at once (even though it is unlikely).
Fix this by using RESTART REPLICA table over RESTART REPLICAS.
And also add a smoke test for
SYSTEM RESTART REPLICAS