Expand macros for fetchPartition#18839
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jan 9, 2021
fastio:expand_macros_for_fetchPartition
Merged
Expand macros for fetchPartition#18839alexey-milovidov merged 2 commits intoClickHouse:masterfrom fastio:expand_macros_for_fetchPartition
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
fastio:expand_macros_for_fetchPartition
Conversation
robot-clickhouse
added
the
pr-improvement
Member
|
@fastio Thank you! Some edits required for build... |
Contributor
Author
The compiling error is fixed now. |
alexey-milovidov
approved these changes
Jan 9, 2021
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
LGTM
There is no tests for this modification - but this is passable.
nikitamikhaylov
added a commit
that referenced
this pull request
Jan 18, 2021
…r_fetchPartition test for #18839 Expand_macros_for_fetchPartition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Expand macros in the zk path when executing fetchPartition.
#18805