Respect MINSIGSTKSZ for alternative stack to fix under aarch64#18832
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jan 7, 2021
Merged
Respect MINSIGSTKSZ for alternative stack to fix under aarch64#18832alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
Member
Author
01600_count_of_parts_metrics is flaky, can someone add force-test label please? |
Member
alexey-milovidov
approved these changes
Jan 7, 2021
Member
Author
|
Looks like CI stuck already, will rebase against upstream/master |
And acording to sigaltstack(2) alignment is not required:
When a signal handler is invoked on the alternate stack, the kernel
automatically aligns the address given in ss.ss_sp to a suitable address
boundary for the underlying hardware architecture.
Fixes: ClickHouse#18785
Member
|
BTW, what is the value of MINSIGSTKSZ on AArch64? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced-in: #16346
Fixes: #18785
Changelog category (leave one):