[For #18707] MySQL compatibility: support DIV and MOD operators#18760
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jan 5, 2021
Merged
[For #18707] MySQL compatibility: support DIV and MOD operators#18760alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
alexey-milovidov
approved these changes
Jan 5, 2021
Member
|
I would also check some corner cases out of curiosity: This query currently works. I expect it to fail after this PR that is also Ok but might require "backward incompatible" label. |
Member
robot-clickhouse
added
pr-backward-incompatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add
DIVandMODoperators.DIVimplements integer division. This is needed for MySQL compatibility and forsqllogictest. This closes #18707. It may introduce incompatibilities if you are using DIV or MOD as column names or aliases. In case of incompatibility, write aliases after AS keyword or wrap identifiers in quotes (either double quotes or backquotes).