Skip to content

Fix Logger with unmatched arg size#18717

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
sundy-li:hotfix-log
Jan 4, 2021
Merged

Fix Logger with unmatched arg size#18717
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
sundy-li:hotfix-log

Conversation

@sundy-li
Copy link
Copy Markdown
Contributor

@sundy-li sundy-li commented Jan 4, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix Logger with unmatched arg size

Detailed description / Documentation draft:

...

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jan 4, 2021
@sundy-li
Copy link
Copy Markdown
Contributor Author

sundy-li commented Jan 4, 2021

Why the compiler can't find this issue?

@alexey-milovidov alexey-milovidov self-assigned this Jan 4, 2021
@alexey-milovidov alexey-milovidov merged commit a4f8a53 into ClickHouse:master Jan 4, 2021
@alexey-milovidov
Copy link
Copy Markdown
Member

Compiler is unaware about fmt library.
BTW, format is included in C++20, so the diagnostics may become better in future: https://en.cppreference.com/w/cpp/utility/format

alexey-milovidov added a commit that referenced this pull request Jan 6, 2021
Backport #18717 to 20.11: Fix Logger with unmatched arg size
alexey-milovidov added a commit that referenced this pull request Jan 6, 2021
Backport #18717 to 20.12: Fix Logger with unmatched arg size
alexey-milovidov added a commit that referenced this pull request Jan 6, 2021
Backport #18717 to 20.9: Fix Logger with unmatched arg size
alexey-milovidov added a commit that referenced this pull request Jan 6, 2021
Backport #18717 to 20.10: Fix Logger with unmatched arg size
alexey-milovidov added a commit that referenced this pull request Feb 19, 2021
Backport #18717 to 20.8: Fix Logger with unmatched arg size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants