Control alter sequential execution more correctly#18518
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
| if (!queue_state.count(alter_version)) | ||
| queue_state.emplace(alter_version, AlterState{.metadata_finished=false, .data_finished=!have_mutation}); | ||
| else /// Data alter can be added before. | ||
| queue_state.emplace(alter_version, AlterState{.metadata_finished=false, .data_finished=true}); |
Member
There was a problem hiding this comment.
Why may ALTER queries hung? Do they wait on data_finished being true?
Member
Author
There was a problem hiding this comment.
Yes, but corresponding data alter can be already killed.
Member
Author
|
Probably this failure with fuzzer is OK. Going to fix test. |
Member
Author
|
Yes, now it's fixed |
This was referenced Dec 29, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 29, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 29, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 29, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 29, 2020
alesapin
added a commit
that referenced
this pull request
Jan 11, 2021
Backport #18518 to 20.10: Control alter sequential execution more correctly
alesapin
added a commit
that referenced
this pull request
Jan 11, 2021
Backport #18518 to 20.11: Control alter sequential execution more correctly
alesapin
added a commit
that referenced
this pull request
Jan 11, 2021
Backport #18518 to 20.12: Control alter sequential execution more correctly
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 18, 2021
alesapin
added a commit
that referenced
this pull request
Feb 19, 2021
Backport #18518 to 20.8: Control alter sequential execution more correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug which may lead to
ALTERqueries hung after corresponding mutation kill. Found by thread fuzzer.