Skip to content

Fix flaky test 01584_distributed_buffer_cannot_find_column#18493

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-flaky-test-buffer
Dec 25, 2020
Merged

Fix flaky test 01584_distributed_buffer_cannot_find_column#18493
alexey-milovidov merged 1 commit intomasterfrom
fix-flaky-test-buffer

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

It failed 8 times in past 100 days,

first seen: db3918d
last seen: e169b39

SELECT test_name, count() AS c, max(check_start_time) AS last_time, argMin(commit_sha, check_start_time) AS first_seen, argMax(commit_sha, check_start_time) AS last_seen FROM `gh-data`.checks
WHERE
    test_status = 'FAIL'
    AND check_name LIKE 'Functional%'
    AND pull_request_number = 0
    AND check_start_time >= now() - INTERVAL 100 DAY
GROUP BY test_name
HAVING last_time >= now() - INTERVAL 3 DAY
ORDER BY c DESC
LIMIT 100

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 25, 2020
/// `table` argument is passed, as it is sometimes evaluated beforehand. It must match the `destination`.
void writeBlockToDestination(const Block & block, StoragePtr table);

void flushBack();
Copy link
Copy Markdown
Member Author

@alexey-milovidov alexey-milovidov Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this method, it was too difficult to read:
the name was similar to "flashback" that leading to confusion.

@alexey-milovidov alexey-milovidov merged commit aba7b5f into master Dec 25, 2020
@alexey-milovidov alexey-milovidov deleted the fix-flaky-test-buffer branch December 25, 2020 09:07
@alexey-milovidov alexey-milovidov self-assigned this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants