Skip to content

Use Port::Data instead of Chunk in LazyOutputFormat.#18411

Merged
alexey-milovidov merged 3 commits intomasterfrom
try-fix-max_result_rows
Dec 30, 2020
Merged

Use Port::Data instead of Chunk in LazyOutputFormat.#18411
alexey-milovidov merged 3 commits intomasterfrom
try-fix-max_result_rows

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Trying to fix 01133_max_result_rows: example
Assuming exception Limit for result exceeded might have happened before one packet with data was sent to client.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 23, 2020
@KochetovNicolai KochetovNicolai marked this pull request as ready for review December 23, 2020 16:52
@alexey-milovidov alexey-milovidov merged commit 9a2b163 into master Dec 30, 2020
@alexey-milovidov alexey-milovidov deleted the try-fix-max_result_rows branch December 30, 2020 23:24
@KochetovNicolai
Copy link
Copy Markdown
Member Author

This pr does not seem to help

KochetovNicolai added a commit that referenced this pull request Jan 3, 2021
…rows"

This reverts commit 9a2b163, reversing
changes made to 5e97df7.
@KochetovNicolai
Copy link
Copy Markdown
Member Author

Reverted: 3a1ec56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants