Skip to content

Fix race in aggregation with combinator distinct#18365

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-group-by-distinct
Dec 23, 2020
Merged

Fix race in aggregation with combinator distinct#18365
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-group-by-distinct

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Dec 22, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible crashes in aggregate functions with combinator Distinct, while using two-level aggregation. Fixes #17682.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 22, 2020
@CurtizJ CurtizJ marked this pull request as draft December 22, 2020 14:33
@CurtizJ CurtizJ marked this pull request as ready for review December 22, 2020 18:30
@alexey-milovidov alexey-milovidov self-assigned this Dec 23, 2020
@alexey-milovidov alexey-milovidov merged commit 0f98fe3 into ClickHouse:master Dec 23, 2020
alexey-milovidov added a commit that referenced this pull request Dec 24, 2020
Backport #18365 to 20.8: Fix race in aggregation with combinator distinct
CurtizJ added a commit that referenced this pull request Dec 24, 2020
Backport #18365 to 20.12: Fix race in aggregation with combinator distinct
CurtizJ added a commit that referenced this pull request Dec 24, 2020
Backport #18365 to 20.10: Fix race in aggregation with combinator distinct
CurtizJ added a commit that referenced this pull request Dec 24, 2020
Backport #18365 to 20.11: Fix race in aggregation with combinator distinct
CurtizJ added a commit that referenced this pull request Dec 24, 2020
Backport #18365 to 20.9: Fix race in aggregation with combinator distinct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server crash with groupArraySample(5)(distinct ...)

3 participants