ISSUES-117 support temporary table management#1824
ISSUES-117 support temporary table management#1824alexey-milovidov merged 11 commits intoClickHouse:masterfrom
Conversation
zhang2014
changed the title
zhang2014
force-pushed
the
fix/ISSUES-117
branch
3 times, most recently
from
b9340f0 to
1070e46
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
1070e46 to
bfe48f1
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
0603d07 to
19e7c29
Compare
zhang2014
changed the title
There was a problem hiding this comment.
Just column->insertDefault() `column->insert(String{})
There was a problem hiding this comment.
Is the new syntax backwards-compatible with the previous one?
There was a problem hiding this comment.
Camel case (externalTables) is used only for function names.
There was a problem hiding this comment.
You could also put column temporary into the block.
It allows excluding the temporary database in case of WHERE temporary != 0
zhang2014
force-pushed
the
fix/ISSUES-117
branch
3 times, most recently
from
3c4987f to
02afa74
Compare
There was a problem hiding this comment.
Could you add an error code?
I would suggest ErrorCodes::SYNTAX_ERROR, but I am not sure it is a syntax error, it is some kind of user error, and the check should be done in the interpreter.
There was a problem hiding this comment.
Could you add the full syntax with NOT LIKE ...
There was a problem hiding this comment.
IMHO it is better to use for-range loop
zhang2014
force-pushed
the
fix/ISSUES-117
branch
2 times, most recently
from
a9d6e66 to
2c3451b
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
2c3451b to
9f66aca
Compare
3 participants
fix #117
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en