Fix enum = Int8 in KeyCondition#18214
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Dec 20, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Dec 20, 2020
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
Ok.
Now UInt8 is also a supertype for UInt8 and Enum8?
Collaborator
Author
Enum8 is treated as Int8 so the super type would be Int16 |
This was referenced Dec 20, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 20, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 20, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 21, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 21, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Dec 23, 2020
Backport #18214 to 20.12: Fix enum = Int8 in KeyCondition
alexey-milovidov
added a commit
that referenced
this pull request
Dec 23, 2020
Backport #18214 to 20.11: Fix enum = Int8 in KeyCondition
alexey-milovidov
added a commit
that referenced
this pull request
Dec 23, 2020
Backport #18214 to 20.10: Fix enum = Int8 in KeyCondition
This was referenced Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix key comparison between Enum and Int types. This fixes #17989
Detailed description / Documentation draft:
.