Skip to content

Fix remove TTL for column#18130

Merged
alesapin merged 3 commits intomasterfrom
fix_remove_column_ttl
Dec 16, 2020
Merged

Fix remove TTL for column#18130
alesapin merged 3 commits intomasterfrom
fix_remove_column_ttl

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Dec 16, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix error when query MODIFY COLUMN ... REMOVE TTL doesn't actually remove column TTL.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 16, 2020
alesapin
alesapin commented Dec 16, 2020
View reviewed changes
src/Storages/AlterCommands.cpp

/// Changes in columns may lead to changes in TTL expressions.
auto column_ttl_asts = metadata_copy.columns.getColumnTTLs();
metadata_copy.column_ttls_by_name.clear();
Copy link
Copy Markdown
Member Author

@alesapin alesapin Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole fix is here.

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Dec 16, 2020 •
edited
Loading 

2020-12-16 11:09:07 01603_remove_column_ttl:                                                [ FAIL ] - result differs with reference:
2020-12-16 11:09:07 --- /ClickHouse/tests/queries/0_stateless/01603_remove_column_ttl.reference	2020-12-16 10:36:30.537843299 +0300
2020-12-16 11:09:07 +++ /ClickHouse/tests/queries/0_stateless/01603_remove_column_ttl.stdout	2020-12-16 11:09:07.768762806 +0300
2020-12-16 11:09:07 @@ -1,6 +1,6 @@
2020-12-16 11:09:07  1	32
2020-12-16 11:09:07 -2	0
2020-12-16 11:09:07 +2	45
2020-12-16 11:09:07  CREATE TABLE default.table_with_column_ttl\n(\n    `EventTime` DateTime,\n    `UserID` UInt64,\n    `Age` UInt8\n)\nENGINE = MergeTree\nORDER BY tuple()\nSETTINGS index_granularity = 8192
2020-12-16 11:09:07  1	32
2020-12-16 11:09:07 -2	0
2020-12-16 11:09:07 +2	45
2020-12-16 11:09:07  3	27
2020-12-16 11:09:07

How is it possible? Downloaded fastest binary and cannot reproduce...

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Dec 16, 2020

Ok, integration test failures are known.

@alesapin alesapin merged commit a999850 into master Dec 16, 2020
@alesapin alesapin deleted the fix_remove_column_ttl branch December 16, 2020 19:05
This was referenced Dec 16, 2020
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 16, 2020
Backport #18130 to 20.10: Fix remove TTL for column
a5e7132
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 16, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 16, 2020
Backport #18130 to 20.9: Fix remove TTL for column
b6bd080
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 16, 2020
Closed
robot-clickhouse pushed a commit that referenced this pull request Dec 16, 2020
Backport #18130 to 20.11: Fix remove TTL for column
d1b5d34
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 16, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 16, 2020
Backport #18130 to 20.12: Fix remove TTL for column
d6ffc91
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 16, 2020
Merged
alesapin added a commit that referenced this pull request Dec 24, 2020
@alesapin
Merge pull request #18165 from ClickHouse/backport/20.11/18130
0f655b9 
Backport #18130 to 20.11: Fix remove TTL for column
alesapin added a commit that referenced this pull request Dec 24, 2020
@alesapin
Merge pull request #18163 from ClickHouse/backport/20.10/18130
b33b6ca 
Backport #18130 to 20.10: Fix remove TTL for column
alesapin added a commit that referenced this pull request Dec 24, 2020
@alesapin
Merge pull request #18166 from ClickHouse/backport/20.12/18130
a1e7e98 
Backport #18130 to 20.12: Fix remove TTL for column
This was referenced Feb 17, 2021
Closed
Closed
@filimonov filimonov mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abyss7 abyss7 abyss7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abyss7 abyss7

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alesapin @abyss7 @robot-clickhouse