Revert "Fix index granularity calculation on block borders"#17918
Merged
Revert "Fix index granularity calculation on block borders"#17918
Conversation
KochetovNicolai
approved these changes
Dec 9, 2020
Member
|
It actually does not loose any data. Wrong information is in marks. It is likely to be fixed by merge. |
Member
Author
|
Fast test OK |
alesapin
added a commit
that referenced
this pull request
Dec 9, 2020
…y_on_block_borders Revert "Fix index granularity calculation on block borders" (cherry picked from commit 4d1f528)
This was referenced Dec 9, 2020
Closed
Closed
Closed
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 5, 2021
In ClickHouse#17120 (that was reverted in ClickHouse#17918 already) marks adjustemnt was introduced, but it may lead to corruption of marks files, that may cause two things: 1) Incorrect marks files, which lead to reading more rows than there are (can be reproduced with `max_threads`>1 or/and `PREWHERE`, and `optimize_move_to_prewhere`) 2) Can't adjust last granule because it has X rows, but try to subtract Y rows (ClickHouse#9260) And 1) is pretty hard to diagnosis, since it does not throw any error, it just may return wrong result. Fortunately both problems can be fixed with `OPTIMIZE TABLE ... [ FINAL]`. Cc: @alesapin Refs: ClickHouse#17943 Refs: ClickHouse#18223
This was referenced Feb 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17120
Contains an awful bug which can lead to
Can't adjust last granule because it has 1024 rows, but try to subtract 1589 rows.: While executing MergeTreeThread.