Fix max_distributed_connections#17848
Merged
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom Dec 15, 2020
Merged
Conversation
With prefer_localhost_replica=1 max_distributed_connections uses max_threads before this patch. Fixes: ClickHouse#14936 Previous fix: ClickHouse#9673
robot-clickhouse
added
the
pr-bugfix
Member
Author
|
CI checks looks unrelated (although I don't know what with the |
Member
Author
@nikitamikhaylov any news? |
nikitamikhaylov
approved these changes
Dec 15, 2020
This was referenced Dec 15, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 15, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 16, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 16, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 16, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Dec 17, 2020
Backport #17848 to 20.12: Fix max_distributed_connections
This was referenced Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 11, 2021
nikitamikhaylov
added a commit
that referenced
this pull request
Mar 12, 2021
Backport #17848 to 20.8: Fix max_distributed_connections
kitaisreal
added a commit
that referenced
this pull request
Mar 20, 2021
kitaisreal
added a commit
that referenced
this pull request
Mar 21, 2021
…17848 Revert "Backport #17848 to 20.8: Fix max_distributed_connections"
alesapin
pushed a commit
that referenced
this pull request
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix max_distributed_connections (affects
prefer_localhost_replica=1andmax_threads!=max_distributed_connections)With
prefer_localhost_replica=1max_distributed_connectionsusesmax_threadsbefore this patch.Fixes: #14936 (cc @KochetovNicolai )