Fix segfault when 'not enough space'#17737
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
abyss7
reviewed
Dec 2, 2020
| } | ||
|
|
||
|
|
||
| ReservationPtr StoragePolicy::reserveAndCheck(UInt64 bytes) const |
Contributor
There was a problem hiding this comment.
Maybe get rid of MergeTreeData::checkAndReturnReservation()? Otherwise it may lead to similar problem, when using functions that required the mentioned method after their invocation.
Member
Author
There was a problem hiding this comment.
It's a good idea, we can rename reserve(...) to tryReserve(...) and reserveAndCheck(...) to just reserve(...), so it will be consistent with other names. But we also have similar reserve(UInt64 bytes) method in Space (IDisk) interface and I don't want to change a lot of signatures in bugfix PR.
Member
Author
|
Stress test (address) and Stress test (memory) - #17744 |
alesapin
approved these changes
Dec 3, 2020
Member
|
Let me rerun some tests. |
This was referenced Dec 5, 2020
alesapin
added a commit
that referenced
this pull request
Dec 5, 2020
…_out_stream Fix segfault when 'not enough space' (cherry picked from commit 0eec52b)
This was referenced Dec 5, 2020
alesapin
added a commit
that referenced
this pull request
Dec 5, 2020
…_out_stream Fix segfault when 'not enough space' (cherry picked from commit 0eec52b)
alesapin
added a commit
that referenced
this pull request
Dec 5, 2020
…_out_stream Fix segfault when 'not enough space' (cherry picked from commit 0eec52b)
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 5, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 5, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 5, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 5, 2020
alesapin
added a commit
that referenced
this pull request
Dec 6, 2020
…_out_stream Fix segfault when 'not enough space' (cherry picked from commit 0eec52b)
This was referenced Feb 17, 2021
alesapin
added a commit
that referenced
this pull request
Feb 18, 2021
…b0a862ba4720f5ef58fa0fcde5fd6 Cherry pick #17737 to 20.8: Fix segfault when 'not enough space'
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 18, 2021
tavplubix
added a commit
that referenced
this pull request
Feb 20, 2021
Backport #17737 to 20.8: Fix segfault when 'not enough space'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed segfault when there is not enough space when inserting into
Distributedtable.Detailed description / Documentation draft:
#17664 (comment)