Skip to content

Fix renameat2 ENOSYS on WSL#17664

Merged
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-2
Dec 2, 2020
Merged

Fix renameat2 ENOSYS on WSL#17664
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-2

Conversation

@tavplubix
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed Function not implemented error when executing RENAME query in Atomic database with ClickHouse running on Windows Subsystem for Linux. Fixes #17661.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 1, 2020
@alexey-milovidov alexey-milovidov self-assigned this Dec 1, 2020
@tavplubix
Copy link
Copy Markdown
Member Author

SIGSEGV in Stress tests is reproducible in master: https://gist.github.com/tavplubix/6c279ad90b0554ec824671b836b43c24

StoragePolicy::reserve(...) may return nullptr, but we do not check it.

Also there are many not enough space errors in Stress tests logs, probably it caused by some issue in Sandbox.

@tavplubix tavplubix merged commit 45b4b36 into master Dec 2, 2020
@tavplubix tavplubix deleted the tavplubix-patch-2 branch December 2, 2020 10:55
vitlibar pushed a commit that referenced this pull request Dec 4, 2020
Backport #17664 to 20.12: Fix renameat2 ENOSYS on WSL
vitlibar pushed a commit that referenced this pull request Dec 4, 2020
Backport #17664 to 20.11: Fix renameat2 ENOSYS on WSL
vitlibar pushed a commit that referenced this pull request Dec 4, 2020
Backport #17664 to 20.9: Fix renameat2 ENOSYS on WSL
vitlibar pushed a commit that referenced this pull request Dec 4, 2020
Backport #17664 to 20.10: Fix renameat2 ENOSYS on WSL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

3 participants