Skip to content

Fix kill mutation on concurrent alter queries#17499

Merged
alesapin merged 1 commit intomasterfrom
concurrent_mutation_and_random_kill
Nov 30, 2020
Merged

Fix kill mutation on concurrent alter queries#17499
alesapin merged 1 commit intomasterfrom
concurrent_mutation_and_random_kill

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix alter query hang when the corresponding mutation was killed on the different replica. Fixes #16953.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 27, 2020
@alesapin
Copy link
Copy Markdown
Member Author

01317_no_password_in_command_line flaky
test_reload_zookeeper/test.py::test_reload_zookeeper fixed in master.

Copy link
Copy Markdown
Member Author

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks well and fix is trivial, I'm going to merge.

@alesapin alesapin merged commit 25f40db into master Nov 30, 2020
@alesapin alesapin deleted the concurrent_mutation_and_random_kill branch November 30, 2020 07:51
alesapin added a commit that referenced this pull request Dec 1, 2020
Backport #17499 to 20.9: Fix kill mutation on concurrent alter queries
alesapin added a commit that referenced this pull request Dec 1, 2020
Backport #17499 to 20.10: Fix kill mutation on concurrent alter queries
alesapin added a commit that referenced this pull request Dec 1, 2020
Backport #17499 to 20.12: Fix kill mutation on concurrent alter queries
alesapin added a commit that referenced this pull request Dec 1, 2020
Backport #17499 to 20.11: Fix kill mutation on concurrent alter queries
alesapin added a commit that referenced this pull request Dec 4, 2020
…dom_kill

Fix kill mutation on concurrent alter queries

(cherry picked from commit 25f40db)
alesapin added a commit that referenced this pull request Feb 19, 2021
Backport #17499 to 20.8: Fix kill mutation on concurrent alter queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In some cases killed mutation lead to unfinished alter

2 participants