Closed
Conversation
added 30 commits
November 27, 2020 15:43
robot-clickhouse
added
the
pr-not-for-changelog
qoega
reviewed
Dec 22, 2020
| <yandex> | ||
| <zookeeper> | ||
| <implementation>testkeeper</implementation> | ||
| <implementation>etcdkeeper</implementation> |
Member
There was a problem hiding this comment.
probably we need to change it from test environment to check different zookeeper alternatives in tests?
Comment on lines
+6
to
+8
| service etcd start && sleep 5 | ||
|
|
||
| echo "Etcd" |
Member
There was a problem hiding this comment.
better make it optional for case when we want to test etcd?
Member
Author
There was a problem hiding this comment.
Of course, It is just for test here in PR.
Member
|
No need for Etcd, let's drop it 🎉 |
Contributor
|
What is the alternative? |
Member
|
@Maokaman1 The chance that this integration with Etcd started to work was neglible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
#10376