Skip to content

Fix some flaky tests#17311

Merged
alesapin merged 10 commits intomasterfrom
fix_integration_tests
Nov 25, 2020
Merged

Fix some flaky tests#17311
alesapin merged 10 commits intomasterfrom
fix_integration_tests

Conversation

@alesapin
Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 23, 2020
@alesapin alesapin changed the title Fix some flaky integration tests Fix some flaky tests Nov 23, 2020
@alesapin
Copy link
Copy Markdown
Member Author

Seems like test_odbc_interaction/test.py::test_sqlite_odbc_hashed_dictionary really broken :(

@alesapin alesapin mentioned this pull request Nov 24, 2020
@alesapin
Copy link
Copy Markdown
Member Author

2020.11.24 18:48:18.605507 [ 36 ] {9a8d5322-25e1-449f-8642-4d69cf33733d} <Error> TCPHandler: Code: 27, e.displayText() = DB::Exception: Cannot parse input: expected '' before: ', 0\n': (at row 1)

Row 1:
Column 0,   name: key,   type: UInt64, ERROR: text ", 0<LINE FEED>" is not like UInt64

: While executing SourceFromInputStream, Stack trace:

0. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x148d592b in /usr/bin/clickhouse
1. /home/alesap/code/cpp/ClickHouse/src/Common/Exception.cpp:40: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x8303a4a in /usr/bin/clickhouse
2. /home/alesap/code/cpp/ClickHouse/src/IO/ReadHelpers.cpp:99: DB::throwAtAssertionFailed(char const*, DB::ReadBuffer&) @ 0x833f7f8 in /usr/bin/clickhouse
3. /home/alesap/code/cpp/ClickHouse/src/IO/ReadHelpers.h:0: DB::skipDelimiter(DB::ReadBuffer&, char, bool) @ 0x11bf8c5f in /usr/bin/clickhouse
4. /home/alesap/code/cpp/ClickHouse/src/Processors/Formats/Impl/CSVRowInputFormat.cpp:0: DB::CSVRowInputFormat::readRow(std::__1::vector<COW<DB::IColumn>::mutable_ptr<DB::IColumn>, std::__1::allocator<COW<DB::IColumn>::mutable_ptr<DB::IColumn> > >&, DB::RowReadExtension&) @ 0x11bf9224 in /usr/bin/clickhouse
5. /home/alesap/code/cpp/ClickHouse/src/Processors/Formats/IRowInputFormat.cpp:66: DB::IRowInputFormat::generate() @ 0x11bcff3c in /usr/bin/clickhouse
6. /home/alesap/code/cpp/ClickHouse/src/Processors/ISource.cpp:48: DB::ISource::work() @ 0x11b3af93 in /usr/bin/clickhouse
7. /home/alesap/code/cpp/ClickHouse/src/Storages/RabbitMQ/RabbitMQBlockInputStream.cpp:116: DB::RabbitMQBlockInputStream::readImpl() @ 0x117accba in /usr/bin/clickhouse
8. /home/alesap/code/cpp/ClickHouse/src/DataStreams/IBlockInputStream.cpp:0: DB::IBlockInputStream::read() @ 0x109338f3 in /usr/bin/clickhouse
9. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/vector:656: DB::ConvertingBlockInputStream::readImpl() @ 0x109328e9 in /usr/bin/clickhouse
10. /home/alesap/code/cpp/ClickHouse/src/DataStreams/IBlockInputStream.cpp:0: DB::IBlockInputStream::read() @ 0x109338f3 in /usr/bin/clickhouse
11. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/vector:656: DB::SourceFromInputStream::generate() @ 0x11cf17ea in /usr/bin/clickhouse
12. /home/alesap/code/cpp/ClickHouse/src/Processors/ISource.cpp:48: DB::ISource::work() @ 0x11b3af93 in /usr/bin/clickhouse
13. /home/alesap/code/cpp/ClickHouse/src/Processors/Sources/SourceFromInputStream.cpp:97: DB::SourceFromInputStream::work() @ 0x11cf14f3 in /usr/bin/clickhouse
14. /home/alesap/code/cpp/ClickHouse/src/Processors/Executors/PipelineExecutor.cpp:98: std::__1::__function::__func<DB::PipelineExecutor::addJob(DB::ExecutingGraph::Node*)::$_0, std::__1::allocator<DB::PipelineExecutor::addJob(DB::ExecutingGraph::Node*)::$_0>, void ()>::operator()() @ 0x11b82f67 in /usr/bin/clickhouse
15. /home/alesap/code/cpp/ClickHouse/src/Processors/Executors/PipelineExecutor.cpp:568: DB::PipelineExecutor::executeStepImpl(unsigned long, unsigned long, std::__1::atomic<bool>*) @ 0x11b80f32 in /usr/bin/clickhouse
16. /home/alesap/code/cpp/ClickHouse/src/Processors/Executors/PipelineExecutor.cpp:0: DB::PipelineExecutor::executeImpl(unsigned long) @ 0x11b7f8d5 in /usr/bin/clickhouse
17. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/memory:2220: DB::PipelineExecutor::execute(unsigned long) @ 0x11b7f39b in /usr/bin/clickhouse
18. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/atomic:957: std::__1::__function::__func<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'(), std::__1::allocator<ThreadFromGlobalPool::ThreadFromGlobalPool<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'()>, void ()>::operator()() @ 0x11b8cd1e in /usr/bin/clickhouse
19. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/functional:1853: ThreadPoolImpl<std::__1::thread>::worker(std::__1::__list_iterator<std::__1::thread, void*>) @ 0x8324c25 in /usr/bin/clickhouse
20. /home/alesap/code/cpp/ClickHouse/contrib/libcxx/include/memory:2615: void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, int, std::__1::optional<unsigned long>)::'lambda1'()> >(void*) @ 0x8328859 in /usr/bin/clickhouse
21. __tsan_thread_start_func @ 0x823e8ad in /usr/bin/clickhouse
22. start_thread @ 0x9669 in /usr/lib/x86_64-linux-gnu/libpthread-2.30.so
23. clone @ 0x1222b3 in /usr/lib/x86_64-linux-gnu/libc-2.30.so

Reproduces only with thread sanitizer.

@alesapin
Copy link
Copy Markdown
Member Author

Release tests unlucky again....

@alesapin
Copy link
Copy Markdown
Member Author

Stress test (undefined) — Killed by signal (in clickhouse-server.log) Will try to investigate (26.2Gb log)

@alesapin alesapin merged commit 3e1b2f5 into master Nov 25, 2020
@alesapin alesapin deleted the fix_integration_tests branch November 25, 2020 07:09
alesapin added a commit that referenced this pull request Dec 5, 2020
Fix some flaky tests

(cherry picked from commit 3e1b2f5)
tavplubix pushed a commit that referenced this pull request Dec 22, 2020
Fix some flaky tests

(cherry picked from commit 3e1b2f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants