Fixed flaky test_storage_s3::test_custom_auth_headers#17299
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Nov 23, 2020
Merged
Fixed flaky test_storage_s3::test_custom_auth_headers#17299alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Nov 23, 2020
Merged
alesapin
pushed a commit
that referenced
this pull request
Dec 5, 2020
Fixed flaky test_storage_s3::test_custom_auth_headers (cherry picked from commit ac710ff)
alesapin
pushed a commit
that referenced
this pull request
Dec 5, 2020
Fixed flaky test_storage_s3::test_custom_auth_headers (cherry picked from commit ac710ff)
alesapin
pushed a commit
that referenced
this pull request
Dec 5, 2020
Fixed flaky test_storage_s3::test_custom_auth_headers (cherry picked from commit ac710ff)
tavplubix
pushed a commit
that referenced
this pull request
Dec 22, 2020
Fixed flaky test_storage_s3::test_custom_auth_headers (cherry picked from commit ac710ff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed flaky test_storage_s3::test_custom_auth_headers
Detailed description / Documentation draft:
Related to test run https://clickhouse-test-reports.s3.yandex.net/17227/f6041c22804d82c0366bbb45e85e33176f419bda/integration_tests_(release).html#fail1
The test sometimes fails because we don't properly wait for custom S3 mock start.