Skip to content

Remove escaping from toString(std::string)#17206

Merged
akuzm merged 3 commits intomasterfrom
aku/noescape
Nov 24, 2020
Merged

Remove escaping from toString(std::string)#17206
akuzm merged 3 commits intomasterfrom
aku/noescape

Conversation

@akuzm
Copy link
Copy Markdown
Contributor

@akuzm akuzm commented Nov 19, 2020

This is just confusing, I'd expect it to be an identity. It looks
especially weird when you do something like toString(Field("don't escape me")). Let's see which tests are going to fail.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This is just confusing, I'd expect it to be an identity. It looks
especially weird when you do something like `toString(Field("don't escape
me"))`. Let's see which tests are going to fail.
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 19, 2020
@akuzm
Copy link
Copy Markdown
Contributor Author

akuzm commented Nov 24, 2020

Test failures are not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants