Remove empty parts after they were pruned by TTL [2]#16895
Merged
alesapin merged 3 commits intoClickHouse:masterfrom Nov 13, 2020
Merged
Remove empty parts after they were pruned by TTL [2]#16895alesapin merged 3 commits intoClickHouse:masterfrom
alesapin merged 3 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
Member
Author
|
This PR contains also #16875 and should be merged after it. |
CurtizJ
changed the title
alesapin
reviewed
Nov 12, 2020
| { | ||
| if (part->rows_count == 0) | ||
| { | ||
| ASTPtr literal = std::make_shared<ASTLiteral>(part->name); |
Member
There was a problem hiding this comment.
quite ugly, better to have separate method for AST, but ok.
| clearOldLogs(); | ||
| clearOldBlocks(); | ||
| clearOldMutations(); | ||
| storage.clearEmptyParts(); |
Member
There was a problem hiding this comment.
What if multiple replicas will assign DROP_RANGE for the same parts almost at the same time. Will it work well? Maybe we will have some exceptions in logs? I hope everything will work well, just need to add comment.
Member
|
Discussed in telegram -- need tiny fixes. |
This was referenced Nov 13, 2020
nikitamikhaylov
added
pr-must-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove empty parts after they were pruned by TTL, mutation, or collapsing merge algorithm.
Detailed description / Documentation draft:
Based on #15511.
Fixes #16629. Fixes #15180. Fixes #5491.