Try to treat input values as enum id in tsv/scv#16834
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Nov 12, 2020
Merged
Try to treat input values as enum id in tsv/scv#16834alexey-milovidov merged 3 commits intoClickHouse:masterfrom
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
doc-alert
pr-feature
src/IO/ReadHelpers.cpp
Outdated
| bool isStringNumber(StringRef str) | ||
| { | ||
| for (size_t i = 0; i != str.size; ++i) | ||
| if (!isdigit(str.data[i])) |
Member
There was a problem hiding this comment.
This function depends on locale that may give surprising results.
Let's replace to isNumericASCII from StringUtils.
src/DataTypes/DataTypeEnum.h
Outdated
| } | ||
|
|
||
| FieldType getValue(StringRef field_name) const | ||
| FieldType getValue(StringRef field_name, bool try_treat_as_id=false) const |
Member
There was a problem hiding this comment.
Whitespace: bool try_treat_as_id = false
alexey-milovidov
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a possibility to input enum value as it's id in TSV and CSV formats by default.
Detailed description / Documentation draft:
Now in TSV and CSV input formats it's possible to write enum id instead of enum name. To avoid ambiguity (enum name could consist digits), first we try to match input string to enum name, if we fail and input string is number, than we try to match this number to enum id.