ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler by zhang2014 · Pull Request #16715 · ClickHouse/ClickHouse

zhang2014 · 2020-11-05T16:15:12Z

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Return number of affected rows for INSERT queries via MySQL protocol. Previously ClickHouse used to always return 0, it's fixed.
Fixes #16605

tavplubix · 2020-11-20T14:41:17Z

Integration tests (thread) - failure is related, data race on affected_rows: https://gist.github.com/tavplubix/638666056d7a067b8938eb4cccb6a128
Seems like we can just make it atomic.

tavplubix · 2020-11-20T14:43:25Z

src/Server/MySQLHandler.cpp

Is it possible that connection_context already have some progress callback? Maybe do something similar to this?

…uery

zhang2014 · 2020-11-23T03:08:09Z

Performance — 5 errors, 5 too long, 2 faster, 72 unstable - unrelated

The test 'materialized_view_parallel_insert' is too slow to run as a whole. Investigate whether the create and fill queries can be sped up
Some query of the test 'materialized_view_parallel_insert' is too slow to run. See the all queries report
The test 'parallel_insert' is too slow to run as a whole. Investigate whether the create and fill queries can be sped up
Some query of the test 'parallel_insert' is too slow to run. See the all queries report
The test 'array_index_low_cardinality_numbers' is too slow to run as a whole. Investigate whether the create and fill queries can be sped up

Integration tests (asan) — fail: 1, not started: 0, passed: 946, error: 0 - unrelated

test_odbc_interaction/test.py::test_postgres_odbc_hached_dictionary_with_schema

Integration tests (release) — fail: 2, not started: 0, passed: 945, error: 0 - unrelated

test_storage_s3/test.py::test_custom_auth_headers
test_odbc_interaction/test.py::test_postgres_odbc_hached_dictionary_with_schema

… rows when insert select query in MySQL handler

…rows when insert select query in MySQL handler

Backport #16715 to 20.11: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

Backport #16715 to 20.10: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

Backport #16715 to 20.12: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

Backport #16715 to 20.9: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

…rows when insert select query in MySQL handler

Backport #16715 to 20.8: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 5, 2020

tavplubix self-assigned this Nov 20, 2020

tavplubix reviewed Nov 20, 2020

View reviewed changes

zhang2014 added 6 commits November 22, 2020 20:13

ISSUES-16605 try fix MySQL handler affected rows when insert select q…

6b2fa22

…uery

ISSUES-16605 add integration test

a6dbba5

ISSUES-16605 try fix integration test failure

5b3154b

ISSUES-16605 try fix integration failure

e1e5eed

trigger CI

0985029

ISSUES-16605 try fix review comment

ade04b5

zhang2014 force-pushed the fix/ISSUES-16605 branch from 0e2e87c to ade04b5 Compare November 22, 2020 12:45

tavplubix approved these changes Nov 22, 2020

View reviewed changes

tavplubix merged commit 7af89cb into ClickHouse:master Nov 23, 2020

robot-clickhouse pushed a commit that referenced this pull request Nov 23, 2020

Backport #16715 to 20.11: ISSUES-16605 fix without returning affected…

3a6061b

… rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Nov 23, 2020

Backport #16715 to 20.11: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #17313

Merged

robot-clickhouse pushed a commit that referenced this pull request Nov 23, 2020

Backport #16715 to 20.10: ISSUES-16605 fix without returning affected…

914030f

… rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Nov 23, 2020

Backport #16715 to 20.10: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #17314

Merged

robot-clickhouse pushed a commit that referenced this pull request Nov 23, 2020

Backport #16715 to 20.12: ISSUES-16605 fix without returning affected…

910f18c

… rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Nov 23, 2020

Backport #16715 to 20.12: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #17315

Merged

robot-clickhouse pushed a commit that referenced this pull request Nov 23, 2020

Backport #16715 to 20.9: ISSUES-16605 fix without returning affected …

6dfa1b4

…rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Nov 23, 2020

Backport #16715 to 20.9: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #17316

Merged

tavplubix added a commit that referenced this pull request Nov 24, 2020

Merge pull request #17313 from ClickHouse/backport/20.11/16715

58f9b40

Backport #16715 to 20.11: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

tavplubix added a commit that referenced this pull request Nov 24, 2020

Merge pull request #17314 from ClickHouse/backport/20.10/16715

25cddda

Backport #16715 to 20.10: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

tavplubix added a commit that referenced this pull request Nov 24, 2020

Merge pull request #17315 from ClickHouse/backport/20.12/16715

dc15a12

Backport #16715 to 20.12: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

tavplubix added a commit that referenced this pull request Nov 24, 2020

Merge pull request #17316 from ClickHouse/backport/20.9/16715

789c7cb

Backport #16715 to 20.9: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Feb 18, 2021

Cherry pick #16715 to 20.8: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #20941

Merged

robot-clickhouse pushed a commit that referenced this pull request Feb 18, 2021

Backport #16715 to 20.8: ISSUES-16605 fix without returning affected …

5a393cc

…rows when insert select query in MySQL handler

robot-clickhouse mentioned this pull request Feb 18, 2021

Backport #16715 to 20.8: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler #20953

Merged

tavplubix added a commit that referenced this pull request Feb 19, 2021

Merge pull request #20953 from ClickHouse/backport/20.8/16715

d0833b9

Backport #16715 to 20.8: ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler#16715

ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler#16715
tavplubix merged 6 commits intoClickHouse:masterfrom
zhang2014:fix/ISSUES-16605

zhang2014 commented Nov 5, 2020 •

edited by tavplubix

Loading

Uh oh!

tavplubix commented Nov 20, 2020

Uh oh!

tavplubix Nov 20, 2020

Uh oh!

zhang2014 commented Nov 23, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zhang2014 commented Nov 5, 2020 • edited by tavplubix Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tavplubix commented Nov 20, 2020

Uh oh!

tavplubix Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

zhang2014 commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhang2014 commented Nov 5, 2020 •

edited by tavplubix

Loading

zhang2014 commented Nov 23, 2020 •

edited

Loading