Merged
Conversation
robot-clickhouse
added
the
pr-build
Member
Author
|
@nikitamikhaylov It works perfectly: |
Member
Author
|
+ you have to name aggregate function camelCase, not CamelCase. |
Member
I thought their name are case-independent. In any case I specified this property in the code |
Member
Author
|
No, for functions that are specific for ClickHouse (as opposed to SQL compatible), better to use case-sensitive names. |
Member
Author
alexey-milovidov
force-pushed
the
harmful
branch
from
99cc0bb to
53ef792
Compare
Member
Author
|
Should be disabled for |
Member
Author
|
Will enable harmful library only in debug builds. |
Member
Member
Author
This was referenced Jan 1, 2021
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jan 8, 2021
This will also fix integrity check (ClickHouse#18811), the reason it does not pops up on CI during PR testing because CI does not set YANDEX_OFFICIAL_BUILD, while it does set it for commits merged into upstream commits, and hence once it was merged the special build was failed. Follow-up for: ClickHouse#16366
Merged
Contributor
|
The log in the description is lost - so what was the motivation? |
Member
Author
|
@abyss7 Don't allow to use harmful functions in code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a library that replaces some
libcfunctions to traps that will terminate the process.Motivated by: https://clickhouse-test-reports.s3.yandex.net/0/c13ab94f91ed4fddd4b9b87adadad68c0ade8684/stress_test_(thread)/stderr.log
Caveats:
fopenstrtok,qsort,bsearch,strptime,localtime,gmtime,drand48_r... in the main source code, but they are Ok for third-party libraries.clickhouse-odbc-bridgeand ClickHouse itself withseccomp.dlopenwill terminate the program immediately. But we are using it in two places and glibc also using it.