Skip to content

Remove cluster type check during ON CLUSTER alter#16075

Merged
tavplubix merged 1 commit intomasterfrom
allow_alter_ddl
Oct 16, 2020
Merged

Remove cluster type check during ON CLUSTER alter#16075
tavplubix merged 1 commit intomasterfrom
allow_alter_ddl

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Oct 16, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now it's allowed to execute ALTER ... ON CLUSTER queries regardless of the <internal_replication> setting in cluster config.

// cc @Alex-Burmak

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 16, 2020
@alesapin alesapin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 16, 2020
@tavplubix tavplubix self-assigned this Oct 16, 2020
@tavplubix
Copy link
Copy Markdown
Member

Functional stateless tests - 01133_max_result_rows - flacky
Stress test (thread) - Sanitizer assert - fixed in #15984

@tavplubix tavplubix merged commit 1773124 into master Oct 16, 2020
@tavplubix tavplubix deleted the allow_alter_ddl branch October 16, 2020 18:20
alesapin added a commit that referenced this pull request Oct 19, 2020
Backport #16075 to 20.10: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.7: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.8: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.9: Remove cluster type check during ON CLUSTER alter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants