Skip to content

Fixing arrayIndex functions when right operand is LC but left is not#16038

Merged
Akazz merged 4 commits intoClickHouse:masterfrom
myrrc:bugfix/lc-arrayIndex-right-operand
Oct 16, 2020
Merged

Fixing arrayIndex functions when right operand is LC but left is not#16038
Akazz merged 4 commits intoClickHouse:masterfrom
myrrc:bugfix/lc-arrayIndex-right-operand

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Oct 15, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes #15780 regression, e.g. indexOf([1, 2, 3], toLowCardinality(1)) now is prohibited but it should not be

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 15, 2020
@Akazz Akazz self-assigned this Oct 15, 2020
@Akazz
Copy link
Copy Markdown
Contributor

Akazz commented Oct 15, 2020

LGTM,
will merge in if tests are okay

@Akazz
Copy link
Copy Markdown
Contributor

Akazz commented Oct 16, 2020

Performance tests "failure" is irrelevant to the subject of this PR

robot-clickhouse pushed a commit that referenced this pull request Oct 16, 2020
robot-clickhouse pushed a commit that referenced this pull request Oct 16, 2020
robot-clickhouse pushed a commit that referenced this pull request Oct 16, 2020
Akazz pushed a commit that referenced this pull request Oct 19, 2020
Akazz pushed a commit that referenced this pull request Oct 19, 2020
Akazz pushed a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20.8 Types of array and 2nd argument of function "indexOf" must be identical up to ...

4 participants