Fix INTERFACE_COMPILE_DEFINITIONS for IMPORTED targets#15828
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Oct 11, 2020
Merged
Fix INTERFACE_COMPILE_DEFINITIONS for IMPORTED targets#15828alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
Conversation
INTERFACE_COMPILE_DEFINITIONS does not work IMPORTED targets:
From 3.6:
Specify compile definitions to use when compiling a given <target>.
The named <target> must have been created by a command such as
add_executable() or add_library() and must not be an Imported Target.
Since 3.11:
Specify compile definitions to use when compiling a given <target>.
The named <target> must have been created by a command such as
add_executable() or add_library() and must not be an ALIAS target.
And this causes the -Wundef warning:
src/Functions/FunctionsHashing.h:1326:5: warning: 'USE_XXHASH' is not defined, evaluates to 0 [-Wundef]
7ee01a6 to
35335f0
Compare
Member
Author
Actually unbundled jemalloc cannot be used, since it includes jemalloc_cpp.o that contains new/delete overrides, so as clickhouse: |
unbundled jemalloc cannot be used, since it includes jemalloc_cpp.o that
contains new/delete overrides, so as clickhouse [1]:
ld.lld: error: duplicate symbol: operator delete(void*, unsigned long)
>>> defined at new_delete.cpp:147 (../src/Common/new_delete.cpp:147)
>>> new_delete.cpp.o:(operator delete(void*, unsigned long)) in archive src/libclickhouse_new_delete.a
>>> defined at jemalloc_cpp.o:(.text+0x160) in archive /usr/lib/x86_64-linux-gnu/libjemalloc.a
[1]: https://clickhouse-builds.s3.yandex.net/15828/35335f07dbf8cab89b4188a674b033c28409dc7b/clickhouse_build_check/build_log_793952627_1602401325.txt
alexey-milovidov
approved these changes
Oct 11, 2020
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Aug 18, 2021
a) MALLOC_LIBARIRIES had been removed in 528e42b ("Improve jemalloc contrib") b) after JEMALLOC_LIBRARIES left, that had been removed in c160b25 ("Drop support for unbundled jemalloc") in ClickHouse#15828
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Dec 22, 2021
Since after ClickHouse#15828 unbundled jemalloc support had been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTERFACE_COMPILE_DEFINITIONS does not work IMPORTED targets:
From 3.6:
Since 3.11:
And this causes the -Wundef warning:
Changelog category (leave one):
Details
HEAD:
INTERFACE GLOBALerror)