Fix prewhere with virtual columns#15756
Merged
alesapin merged 1 commit intoClickHouse:masterfrom Oct 9, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
CurtizJ
changed the title
Contributor
|
Does it also fix #13993 ? |
Member
Author
No. |
alesapin
approved these changes
Oct 9, 2020
Member
|
Test failures don't seem to be related to changes. |
This was referenced Oct 9, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 9, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 9, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 9, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 9, 2020
CurtizJ
added a commit
that referenced
this pull request
Oct 11, 2020
Backport #15756 to 20.9: Fix prewhere with virtual columns
CurtizJ
added a commit
that referenced
this pull request
Oct 11, 2020
Backport #15756 to 20.7: Fix prewhere with virtual columns
CurtizJ
added a commit
that referenced
this pull request
Oct 11, 2020
Backport #15756 to 20.8: Fix prewhere with virtual columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix some cases of queries, in which only virtual columns are selected. Previously
Not found column _nothing in blockexception may be thrown. Fixes #12298.Detailed description / Documentation draft:
Chunk with empty set of columns can appear in case, when only virtual columns are selected and column, which is used only for prewhere was dropped. Now it's ok to create such chunks with non-zero number of rows, as it will be done here.
empty()method of chunk will returnfalse, and since chunk has non-zero number of rows, virtual columns will be injected here