Skip to content

Fix assertion with setting transform_null_in#15731

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-tranform-null-in
Oct 8, 2020
Merged

Fix assertion with setting transform_null_in#15731
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-tranform-null-in

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Oct 7, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #15237.

This PR just fixes the fuzzer report, but functionality with enabled transform_null_in is still broken in some cases. See #15310.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 7, 2020
@alexey-milovidov alexey-milovidov self-assigned this Oct 7, 2020
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Oct 8, 2020

Test failures are not related to changes.

@CurtizJ CurtizJ merged commit 4bc4042 into ClickHouse:master Oct 8, 2020
CurtizJ added a commit that referenced this pull request Nov 16, 2020
Fix assertion with setting transform_null_in

(cherry picked from commit 4bc4042)
CurtizJ added a commit that referenced this pull request Nov 16, 2020
Fix assertion with setting transform_null_in

(cherry picked from commit 4bc4042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

src/Core/Field.h:772: Assertion `target == which || (isInt64FieldType(target) && isInt64FieldType(which)) || target == Field::Types::Decimal64' failed.

3 participants