Cancel other processors on query exception#15578
Merged
abyss7 merged 2 commits intoClickHouse:masterfrom Oct 6, 2020
Merged
Conversation
Fixes: 01514_distributed_cancel_query_on_error
robot-clickhouse
added
the
pr-bugfix
Member
Author
Does not looks related |
Member
I thought it was already working this way. |
KochetovNicolai
approved these changes
Oct 6, 2020
Member
So did I. |
This was referenced Oct 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 6, 2020
alesapin
pushed a commit
to alexelex/ClickHouse
that referenced
this pull request
Oct 8, 2020
* Add a test for canceling distributed queries on error * Cancel other processors on exception in PipelineExecutor Fixes: 01514_distributed_cancel_query_on_error
alexey-milovidov
added a commit
that referenced
this pull request
Nov 14, 2020
Backport #15578 to 20.9: Cancel other processors on query exception
alexey-milovidov
added a commit
that referenced
this pull request
Nov 14, 2020
Backport #15578 to 20.8: Cancel other processors on query exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Query is finished faster in case of exception. Cancel execution on remote replicas if exception happens.
Detailed description / Documentation draft:
For example this will cancel remote queries on other shards as soon as the query fail on one of them
Cc: @KochetovNicolai