Skip to content

Fix mutation may hang after REPLACE/DROP PARTITION#15537

Merged
tavplubix merged 5 commits intomasterfrom
mutation_hangs_after_replace_partition
Oct 7, 2020
Merged

Fix mutation may hang after REPLACE/DROP PARTITION#15537
tavplubix merged 5 commits intomasterfrom
mutation_hangs_after_replace_partition

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Oct 2, 2020 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Mutation might hang waiting for some non-existent part after MOVE or REPLACE PARTITION or, in rare cases, after DETACH or DROP PARTITION. It's fixed.

Detailed description / Documentation draft:
Actually fixes two independent bugs: wrong covering part for partition in REPLACE_RANGE and excess virtual parts in parts_to_do

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Oct 2, 2020
@tavplubix tavplubix mentioned this pull request Oct 2, 2020
Closed
@alesapin alesapin self-assigned this Oct 2, 2020
@tavplubix tavplubix force-pushed the mutation_hangs_after_replace_partition branch from 2a7432d to bd790f3 Compare October 2, 2020 19:35
@alesapin alesapin removed their assignment Oct 5, 2020
@tavplubix tavplubix marked this pull request as ready for review October 5, 2020 19:17
@tavplubix tavplubix changed the title Add test: Mutation may hang after REPLACE PARTITION Fix mutation may hang after REPLACE/DROP PARTITION Oct 5, 2020
@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default and removed pr-feature Pull request with new product feature labels Oct 5, 2020
@abyss7 abyss7 self-assigned this Oct 6, 2020
@abyss7 abyss7 self-requested a review October 6, 2020 14:24
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Oct 7, 2020

AST fuzzer — Received signal 6 - reported
Performance - unrelated

@tavplubix tavplubix merged commit 0410155 into master Oct 7, 2020
@tavplubix tavplubix deleted the mutation_hangs_after_replace_partition branch October 7, 2020 11:25
This was referenced Oct 7, 2020
Merged
Merged
Merged
Merged
tavplubix added a commit that referenced this pull request Oct 7, 2020
@tavplubix
Merge pull request #15537 from ClickHouse/mutation_hangs_after_replac…
4bfe985 
…e_partition

Fix mutation may hang after REPLACE/DROP PARTITION

(cherry picked from commit 0410155)
robot-clickhouse pushed a commit that referenced this pull request Oct 7, 2020
Backport #15537 to 20.9: Fix mutation may hang after REPLACE/DROP PAR…
cae473e 
…TITION
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 7, 2020
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 7, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 7, 2020
Backport #15537 to 20.7: Fix mutation may hang after REPLACE/DROP PAR…
3ad4d62 
…TITION
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 7, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 7, 2020
Backport #15537 to 20.6: Fix mutation may hang after REPLACE/DROP PAR…
0ab359d 
…TITION
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 7, 2020
Merged
tavplubix added a commit that referenced this pull request Oct 7, 2020
@tavplubix
Backport #15537 to 20.3 (#15724)
fac5dd6 
* Merge pull request #15537 from ClickHouse/mutation_hangs_after_replace_partition

Fix mutation may hang after REPLACE/DROP PARTITION

(cherry picked from commit 0410155)

* Update 01149_zookeeper_mutation_stuck_after_replace_partition.sql
tavplubix added a commit that referenced this pull request Oct 7, 2020
@robot-clickhouse @tavplubix
Backport #15537 to 20.6: Fix mutation may hang after REPLACE/DROP PAR…
ba06bbb 
…TITION (#15728)

* Backport #15537 to 20.6: Fix mutation may hang after REPLACE/DROP PARTITION

* Update 01149_zookeeper_mutation_stuck_after_replace_partition.sql

Co-authored-by: tavplubix <[email protected]>
tavplubix added a commit that referenced this pull request Oct 7, 2020
@robot-clickhouse @tavplubix
Backport #15537 to 20.7: Fix mutation may hang after REPLACE/DROP PAR…
31f429a 
…TITION (#15727)

* Backport #15537 to 20.7: Fix mutation may hang after REPLACE/DROP PARTITION

* Update 01149_zookeeper_mutation_stuck_after_replace_partition.sql

Co-authored-by: tavplubix <[email protected]>
tavplubix added a commit that referenced this pull request Oct 7, 2020
@robot-clickhouse @tavplubix
Backport #15537 to 20.9: Fix mutation may hang after REPLACE/DROP PAR…
08f2996 
…TITION (#15725)

* Backport #15537 to 20.9: Fix mutation may hang after REPLACE/DROP PARTITION

* Update 01149_zookeeper_mutation_stuck_after_replace_partition.sql

Co-authored-by: tavplubix <[email protected]>
tavplubix added a commit that referenced this pull request Oct 7, 2020
@robot-clickhouse @tavplubix
Backport #15537 to 20.8: Fix mutation may hang after REPLACE/DROP PAR…
1b935db 
…TITION (#15726)

* Backport #15537 to 20.8: Fix mutation may hang after REPLACE/DROP PARTITION

* Update 01149_zookeeper_mutation_stuck_after_replace_partition.sql

Co-authored-by: tavplubix <[email protected]>
@tavplubix tavplubix mentioned this pull request Jan 22, 2021
Merged
tavplubix added a commit that referenced this pull request Jan 26, 2021
@tavplubix
Merge pull request #19443 from ClickHouse/fix_virtual_parts_in_parts_…
2d6a71f 
…to_do

Addition to #15537
robot-clickhouse pushed a commit that referenced this pull request Jan 26, 2021
Backport #19443 to 20.12: Addition to #15537
2734fd3
robot-clickhouse pushed a commit that referenced this pull request Jan 26, 2021
Backport #19443 to 20.10: Addition to #15537
eaf4eaa
robot-clickhouse pushed a commit that referenced this pull request Jan 26, 2021
Backport #19443 to 20.11: Addition to #15537
bf66bdd
robot-clickhouse pushed a commit that referenced this pull request Jan 26, 2021
Backport #19443 to 21.1: Addition to #15537
57d369f
tavplubix added a commit that referenced this pull request Jan 26, 2021
@tavplubix
Merge pull request #19613 from ClickHouse/backport/20.10/19443
60a1f44 
Backport #19443 to 20.10: Addition to #15537
tavplubix added a commit that referenced this pull request Jan 26, 2021
@tavplubix
Merge pull request #19614 from ClickHouse/backport/20.11/19443
d4b7217 
Backport #19443 to 20.11: Addition to #15537
tavplubix added a commit that referenced this pull request Jan 26, 2021
@tavplubix
Merge pull request #19615 from ClickHouse/backport/21.1/19443
7478c70 
Backport #19443 to 21.1: Addition to #15537
tavplubix added a commit that referenced this pull request Jan 26, 2021
@tavplubix
Merge pull request #19612 from ClickHouse/backport/20.12/19443
d85b68b 
Backport #19443 to 20.12: Addition to #15537
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 1, 2021
Closed
robot-clickhouse pushed a commit that referenced this pull request Feb 18, 2021
Backport #19443 to 20.8: Addition to #15537
faf9fd9
tavplubix added a commit that referenced this pull request Feb 19, 2021
@tavplubix
Merge pull request #20894 from ClickHouse/backport/20.8/19443
eb94938 
Backport #19443 to 20.8: Addition to #15537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abyss7 abyss7 abyss7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abyss7 abyss7

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tavplubix @abyss7 @alesapin @robot-clickhouse