Skip to content

Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it#15516

Merged
alesapin merged 1 commit intoClickHouse:masterfrom
nvartolomei:nv/error-out-for-wrong-parameters-replicatedmergetree
Oct 2, 2020
Merged

Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it#15516
alesapin merged 1 commit intoClickHouse:masterfrom
nvartolomei:nv/error-out-for-wrong-parameters-replicatedmergetree

Conversation

@nvartolomei
Copy link
Copy Markdown
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it

Detailed description / Documentation draft:

...

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 1, 2020
@nvartolomei
Copy link
Copy Markdown
Contributor Author

nvartolomei commented Oct 1, 2020

The error message before that was still hard to understand and required digging through the code.

CREATE TABLE mt (v UInt8) ENGINE = ReplicatedMergeTree('/clickhouse/tables/test_01497/mt') order by tuple()
TCPHandler: Code: 62, e.displayText() = DB::Exception: Macro 'uuid' and empty arguments of ReplicatedMergeTree are supported only for ON CLUSTER queries with Atomic database engine, Stack trace:

@alesapin alesapin merged commit c0d1416 into ClickHouse:master Oct 2, 2020
@alesapin alesapin self-assigned this Oct 2, 2020
robot-clickhouse pushed a commit that referenced this pull request Oct 5, 2020
…ssed to ReplicatedMergeTree instead of ignoring it
robot-clickhouse pushed a commit that referenced this pull request Oct 5, 2020
…ssed to ReplicatedMergeTree instead of ignoring it
robot-clickhouse pushed a commit that referenced this pull request Oct 5, 2020
…ssed to ReplicatedMergeTree instead of ignoring it
alesapin added a commit that referenced this pull request Oct 9, 2020
Backport #15516 to 20.8: Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
alesapin added a commit that referenced this pull request Oct 9, 2020
Backport #15516 to 20.9: Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
@nvartolomei nvartolomei deleted the nv/error-out-for-wrong-parameters-replicatedmergetree branch June 4, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants