Fixed compression in S3 storage#15376
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom Oct 1, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
Contributor
|
Can we have a test that covers this variant of grammar? |
excitoon
changed the title
format argument in S3 storage when compression method is selected
Contributor
Author
|
The bug turned out to be even bigger thing than just wrong reading of argument - it was not used afterwards. |
excitoon
force-pushed
the
fixs3storage
branch
from
84b9ddf to
a38c7ff
Compare
Contributor
Author
Done. |
excitoon
force-pushed
the
fixs3storage
branch
from
faed10a to
0497ce4
Compare
alexey-milovidov
approved these changes
Oct 1, 2020
This was referenced Oct 1, 2020
excitoon
added a commit
to excitoon-favorites/ClickHouse
that referenced
this pull request
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed compression in S3 storage.
Fixes #13871