Check pid file contents inside clickhouse server#1498
Merged
alexey-milovidov merged 8 commits intoClickHouse:masterfrom Nov 16, 2017
Merged
Check pid file contents inside clickhouse server#1498alexey-milovidov merged 8 commits intoClickHouse:masterfrom
alexey-milovidov merged 8 commits intoClickHouse:masterfrom
Conversation
libs/libdaemon/src/BaseDaemon.cpp
Outdated
|
|
||
| bool is_pid_running(pid_t pid) | ||
| { | ||
| if (0 == kill(pid, 0)) |
Member
There was a problem hiding this comment.
If sig is 0, then no signal is sent, but existence and permission checks are still performed; this can be used to check for the existence of a process ID or process group ID that the caller is permitted to signal.
Excessive check. There is the possibility that the process is running from different user.
libs/libdaemon/src/BaseDaemon.cpp
Outdated
|
|
||
| bool is_pid_running(pid_t pid) | ||
| { | ||
| if (0 == kill(pid, 0)) |
libs/libdaemon/src/BaseDaemon.cpp
Outdated
| ); | ||
| } | ||
|
|
||
| bool is_pid_running(pid_t pid) |
| std::ifstream in(file); | ||
| if (in.good()) | ||
| { | ||
| in >> pid_read; |
Member
There was a problem hiding this comment.
No error checks.
Why don't you use ReadBuffer?
libs/libdaemon/src/BaseDaemon.cpp
Outdated
| throw Poco::Exception("Pid file exists and program running with pid = " + std::to_string(pid_read) + ", should not start daemon."); | ||
| } | ||
| } | ||
| std::cerr << "Old pid file exists (with pid = " << pid_read << "), removing."; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.