Fix enable_optimize_predicate_expression for finalizeAggregation#14937
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Sep 17, 2020
Merged
Conversation
finalizeAggregation was wrongly marked as stateful, preventing pushing the conditions down.
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Sep 17, 2020
Member
Does not matter - ignore. |
This was referenced Sep 17, 2020
Merged
Merged
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
… finalizeAggregation
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
… finalizeAggregation
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
… finalizeAggregation
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
… finalizeAggregation
|
I made a PR to backport this to 20.3 #15231 |
Member
|
Actually it's not a bugfix. But backporting it should be easy. We only have to fix some whitespaces in the test reference... |
Member
|
I will try to merge these backports. |
alexey-milovidov
added a commit
that referenced
this pull request
Sep 30, 2020
Backport #14937 to 20.6: Fix enable_optimize_predicate_expression for finalizeAggregation
alexey-milovidov
added a commit
that referenced
this pull request
Sep 30, 2020
Backport #14937 to 20.8: Fix enable_optimize_predicate_expression for finalizeAggregation
alexey-milovidov
added a commit
that referenced
this pull request
Sep 30, 2020
Backport #14937 to 20.9: Fix enable_optimize_predicate_expression for finalizeAggregation
alexey-milovidov
added a commit
that referenced
this pull request
Sep 30, 2020
Backport #14937 to 20.7: Fix enable_optimize_predicate_expression for finalizeAggregation
alexey-milovidov
added a commit
that referenced
this pull request
Oct 7, 2020
Back port #14937 "Fix enable_optimize_predicate_expression for finalizeAggregation" to 20.3 LTS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix to make predicate push down work when subquery contains finalizeAggregation function. Fixes #14847
Detailed description / Documentation draft: