Allow Atomic database inside MaterializeMySQL#14849
Merged
Conversation
robot-clickhouse
added
the
pr-improvement
This was referenced Oct 9, 2020
abyss7
approved these changes
Nov 10, 2020
Contributor
abyss7
left a comment
abyss7
left a comment
There was a problem hiding this comment.
Please, merge with master.
| else if (query.kind == ASTDropQuery::Kind::Detach) | ||
| { | ||
| if (auto * atomic = typeid_cast<DatabaseAtomic *>(database.get())) | ||
| if (auto * atomic = dynamic_cast<DatabaseAtomic *>(database.get())) |
Contributor
There was a problem hiding this comment.
In other places it's a check for UUID to detect Atomic DB. Why dynamic_cast here?
src/Interpreters/DatabaseCatalog.cpp
Outdated
| { | ||
| if (!MaterializeMySQLSyncThread::isMySQLSyncThread()) | ||
| db_and_table.second = std::make_shared<StorageMaterializeMySQL>(std::move(db_and_table.second), db_and_table.first.get()); | ||
| return db_and_table; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow using
Atomicengine for nested database ofMaterializeMySQLengine.cc: @zhang2014 @bohutang