dynamic zookeeper config when session expired#14678
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Sep 17, 2020
Merged
dynamic zookeeper config when session expired#14678alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
Contributor
Author
|
Processes:
|
sundy-li
force-pushed
the
patch-2
branch
2 times, most recently
from
340687a to
9c274c1
Compare
fix logic error && skip reload testkeeper
alexey-milovidov
approved these changes
Sep 17, 2020
Member
|
Yes, it is very valuable change. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
dynamic reload zookeeper config
Detailed description / Documentation draft:
Is it ok to use the latest zookeeper config if zookeeper session expired? It's for the reason when we scale and shrink the zookeeper clusters, we may need to modify and restart the clickhouse-server. A little painful for the whole clusters.