Conversation
Member
Author
|
Only some asserts and test added, but I'm going to fix it. |
Member
Author
|
I think it's quite a rare bug and reproduction steps without mutation will be quite complicated. I think bug exists for a long time but triggered with one of |
KochetovNicolai
approved these changes
Sep 11, 2020
Member
Author
|
Performance OK |
This was referenced Sep 14, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 14, 2020
…ain const nullable column
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 14, 2020
…ain const nullable column
alesapin
added a commit
that referenced
this pull request
Sep 14, 2020
Fix bug in if function when then clause contain const nullable column (cherry picked from commit 336430d)
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 14, 2020
…ain const nullable column
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 14, 2020
…ain const nullable column
Contributor
|
to 20.3? |
alesapin
added a commit
that referenced
this pull request
Sep 14, 2020
Backport #14646 to 20.9: Fix bug in if function when then clause contain const nullable column
alesapin
added a commit
that referenced
this pull request
Sep 14, 2020
Backport #14646 to 20.8: Fix bug in if function when then clause contain const nullable column
alesapin
added a commit
that referenced
this pull request
Sep 14, 2020
Backport #14646 to 20.6: Fix bug in if function when then clause contain const nullable column
Member
|
@filimonov Sure. We have backported it. |
alesapin
added a commit
that referenced
this pull request
Sep 15, 2020
Backport #14646 to 20.7: Fix bug in if function when then clause contain const nullable column
This was referenced Sep 19, 2020
traceon
added a commit
to traceon/ClickHouse
that referenced
this pull request
Sep 20, 2020
* master: (375 commits) Update type-conversion-functions.md Update maxmap.md Update maxmap.md Update maxmap.md Update single_fixed_string_groupby.xml Alter remove column properties and TTLs (ClickHouse#14742) better fixed string group by support Fix incorrect key condition of fixed strings. constant output order more tests for ClickHouse#14646 Maybe fix MSan report in base64 Proper exception message for wrong number of arguments of CAST Added a test Fix buffer overflow in "bar" function Update convertMySQLDataType.cpp Fix clang-tidy Remove obsolete code from performance test Slightly better code Even more Even more ... # Conflicts: # src/Interpreters/Context.cpp
traceon
added a commit
to traceon/ClickHouse
that referenced
this pull request
Sep 21, 2020
* ldap-any-user-authentication: (781 commits) Remove extra declaration Synchronize the code with respect to IAccessStorage::login() functionality Update type-conversion-functions.md Update maxmap.md Update maxmap.md Update maxmap.md Update single_fixed_string_groupby.xml Alter remove column properties and TTLs (ClickHouse#14742) better fixed string group by support Fix incorrect key condition of fixed strings. constant output order more tests for ClickHouse#14646 Maybe fix MSan report in base64 Proper exception message for wrong number of arguments of CAST Added a test Fix buffer overflow in "bar" function Update convertMySQLDataType.cpp Fix clang-tidy Remove obsolete code from performance test Slightly better code ... # Conflicts: # src/Access/ContextAccess.cpp # src/Access/ContextAccess.h # src/Access/ExternalAuthenticators.h # src/Access/LDAPAccessStorage.cpp # src/Access/LDAPClient.h # src/Access/LDAPParams.h # src/Common/ErrorCodes.cpp # src/Interpreters/Context.cpp # src/Interpreters/Context.h
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug when
ALTER UPDATEmutation with Nullable column in assignment expression and constant value (likeUPDATE x = 42) leads to incorrect value in column or segfault. Fixes #13634, #14045.