Use join() instead of detach() for threads #2#14604
Merged
vitlibar merged 1 commit intoClickHouse:masterfrom Sep 11, 2020
Merged
Use join() instead of detach() for threads #2#14604vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar merged 1 commit intoClickHouse:masterfrom
Conversation
vitlibar
added
pr-bugfix
vitlibar
force-pushed
the
no-detach-threads-2
branch
2 times, most recently
from
b1b1c4c to
95a8cc6
Compare
vitlibar
force-pushed
the
no-detach-threads-2
branch
from
95a8cc6 to
2a9ab48
Compare
Member
Author
|
The failed performance tests have nothing to do with |
This was referenced Sep 11, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
This fixes thread leak in
StorageLiveView(https://clickhouse-test-reports.s3.yandex.net/14404/7ca155c417a4ac64f448c390cc5f5462540b204f/stress_test_(thread)/stderr.log).