Skip to content

Retries in s3 downloader#14578

Merged
alesapin merged 4 commits intomasterfrom
retries_in_s3_downloader
Sep 8, 2020
Merged

Retries in s3 downloader#14578
alesapin merged 4 commits intomasterfrom
retries_in_s3_downloader

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Sep 8, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@alesapin alesapin added the testing Special issue with list of bugs found by CI label Sep 8, 2020
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 8, 2020
percent = int(100 * float(dl) / total_length)
sys.stdout.write("\r[{}{}] {}%".format('=' * done, ' ' * (50-done), percent))
sys.stdout.flush()
for i in range(RETRIES_COUNT):
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, docker doesn't support symlinks and require all files to be in Dockerfile's directory. So we have to support to copies :(

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Sep 8, 2020

Ok, let's merge without tests.

@alesapin alesapin merged commit 4aad57d into master Sep 8, 2020
@alesapin alesapin deleted the retries_in_s3_downloader branch September 8, 2020 09:53
@qoega qoega mentioned this pull request Sep 9, 2020
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog testing Special issue with list of bugs found by CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants