Stop query execution if exception happened in PipelineExecutor itself.#14402
Merged
KochetovNicolai merged 2 commits intomasterfrom Sep 4, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
vitlibar
reviewed
Sep 2, 2020
| for (auto & executor_context : executor_contexts) | ||
| if (executor_context->exception) | ||
| std::rethrow_exception(executor_context->exception); | ||
|
|
Member
There was a problem hiding this comment.
It seems executeStepImpl() never set executor_context->exception, so this cycle doesn't look useful.
Member
Author
There was a problem hiding this comment.
Right. Wring place.
vitlibar
reviewed
Sep 2, 2020
| @@ -735,7 +731,16 @@ void PipelineExecutor::executeImpl(size_t num_threads) | |||
| CurrentThread::detachQueryIfNotDetached(); | |||
Member
There was a problem hiding this comment.
It's not easy to understand the difference between these execute* functions.
Probably it's better to rename executeImpl() to something like executeMultipleThreads()?
Member
Author
There was a problem hiding this comment.
Agree.
Will fix it in other pr.
vitlibar
approved these changes
Sep 4, 2020
Member
Author
|
|
KochetovNicolai
deleted the
stop-threads-if-exception-in-pipeline-executor
branch
This was referenced Sep 4, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 4, 2020
…n PipelineExecutor itself.
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 4, 2020
…n PipelineExecutor itself.
KochetovNicolai
added a commit
that referenced
this pull request
Sep 7, 2020
…n-pipeline-executor Stop query execution if exception happened in PipelineExecutor itself. (cherry picked from commit 01d0f6e)
KochetovNicolai
added a commit
that referenced
this pull request
Sep 7, 2020
Backport #14402 to 20.8: Stop query execution if exception happened in PipelineExecutor itself.
KochetovNicolai
added a commit
that referenced
this pull request
Sep 7, 2020
Backport #14402 to 20.7: Stop query execution if exception happened in PipelineExecutor itself.
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 7, 2020
…n PipelineExecutor itself.
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 7, 2020
…n PipelineExecutor itself.
KochetovNicolai
added a commit
that referenced
this pull request
Sep 8, 2020
Backport #14402 to 20.6: Stop query execution if exception happened in PipelineExecutor itself.
KochetovNicolai
added a commit
that referenced
this pull request
Sep 8, 2020
Backport #14402 to 20.5: Stop query execution if exception happened in PipelineExecutor itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Stop query execution if exception happened in
PipelineExecutoritself. This could prevent rare possible query hung. Continuation of #14334